Skip to content

refactor: extract suggestion entry session helpers#340

Merged
bartekplus merged 4 commits intomasterfrom
codex/suggestion-session-helper-extraction
Mar 22, 2026
Merged

refactor: extract suggestion entry session helpers#340
bartekplus merged 4 commits intomasterfrom
codex/suggestion-session-helper-extraction

Conversation

@bartekplus
Copy link
Owner

Summary

  • extract cursor-context and input-action derivation from SuggestionEntrySession into focused helper modules
  • extract accepted-suggestion transient state and keydown policy into a dedicated helper module with targeted unit coverage
  • keep SuggestionEntrySession focused on orchestration while preserving existing suggestion runtime behavior

Scope

  • This PR is a focused first pass on src/adapters/chrome/content-script/suggestions
  • It does not complete the broader repo-wide unification/refactor across all src files and modules

Test Plan

  • bun run typecheck
  • bun test tests/SuggestionEntryPredictionContext.test.ts tests/SuggestionAcceptedState.test.ts tests/SuggestionEntrySession.test.ts
  • bun run test

@bartekplus bartekplus merged commit 2bfdfa0 into master Mar 22, 2026
8 checks passed
@bartekplus bartekplus deleted the codex/suggestion-session-helper-extraction branch March 22, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant